Add support for v3 of the AssemblyStore format #4516
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## net10 #4516 +/- ##
==========================================
+ Coverage 71.77% 72.93% +1.15%
==========================================
Files 479 476 -3
Lines 17508 17213 -295
Branches 3442 3419 -23
==========================================
- Hits 12567 12554 -13
+ Misses 4090 3808 -282
Partials 851 851 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
test/Sentry.Android.AssemblyReader.Tests/ApiApprovalTests.Run.DotNet10_0.verified.txt
Show resolved
Hide resolved
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| brew install mono || true | ||
| brew link --overwrite mono | ||
| - name: Install Mono (Ubuntu) |
There was a problem hiding this comment.
Was this intentionally removed, or did something go wrong with the merges?
There was a problem hiding this comment.
Definitely something wrong with the merges... which is painful. Looks like I'll have to roll it all back manually.
| - Bump Cocoa SDK from v8.55.1 to v8.56.0 ([#4528](https://github.com/getsentry/sentry-dotnet/pull/4528)) | ||
| - [changelog](https://github.com/getsentry/sentry-cocoa/blob/main/CHANGELOG.md#8560) | ||
| - [diff](https://github.com/getsentry/sentry-cocoa/compare/8.55.1...8.56.0) | ||
| - Bump CLI from v2.53.0 to v2.54.0 ([#4541](https://github.com/getsentry/sentry-dotnet/pull/4541)) | ||
| - [changelog](https://github.com/getsentry/sentry-cli/blob/master/CHANGELOG.md#2540) | ||
| - [diff](https://github.com/getsentry/sentry-cli/compare/2.53.0...2.54.0) | ||
| - Bump Native SDK from v0.10.1 to v0.11.0 ([#4542](https://github.com/getsentry/sentry-dotnet/pull/4542)) | ||
| - [changelog](https://github.com/getsentry/sentry-native/blob/master/CHANGELOG.md#0110) | ||
| - [diff](https://github.com/getsentry/sentry-native/compare/0.10.1...0.11.0) |
There was a problem hiding this comment.
These downgrades (see also Directory.Build.props, modules/sentry-cocoa.properties, modules/sentry-native, ...) don't seem intended, are they?
| [Theory] | ||
| [InlineData(true)] | ||
| [InlineData(false)] | ||
| public void ProcessOnBeforeSend_NativeErrorSuppressionBeforeHubInit(bool suppressNativeErrors) |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| } | ||
|
|
||
| public StoreReaderV2(Stream store, string path, DebugLogger? logger) | ||
| public StoreReader(Stream store, string path, DebugLogger? logger) |
There was a problem hiding this comment.
Bug: StoreReader Compilation Issues Affect Backward Compatibility
The StoreReader has inconsistent conditional compilation for assembly store format versions and the ignore byte. This can lead to incorrect parsing when built for certain target frameworks, and also prevents backward compatibility, as .NET 10+ builds currently only support v3, failing to read .NET 9 (v2) APKs.
|
Replaced with #4576 |
5 participants
Resolves #4491
Warning
This is a fork of the net10 branch... once that branch has been squashed/merged into the v6 branch we can look at squashing/merging into the same